Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd88c4) 73.03% compared to head (2fca6dc) 73.03%.

❗ Current head 2fca6dc differs from pull request most recent head bd57467. Consider uploading reports for the commit bd57467 to get more accurate results

@@           Coverage Diff           @@
##           master     #679   +/-   ##
=======================================
  Coverage   73.03%   73.03%           
=======================================
  Files          48       48           
  Lines        7841     7841           
=======================================
  Hits         5727     5727           
  Misses       2114     2114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks, the principle looks good, I'll take some time later to carefully review the macro.

More generally for this change, would you mind:

• Add some text in the documentation of the macro explaining how to use it
• Introduce the same change in wayland-server as well which has a similar macro
• Add relevant entries to the changelog of the two crates

Thanks, the principle looks good, I'll take some time later to carefully review the macro.

More generally for this change, would you mind:

* Add some text in the documentation of the macro explaining how to use it

* Introduce the same change in `wayland-server` as well which has a similar macro

* Add relevant entries to the changelog of the two crates

Sure, I am happy to do this

Does the macro as it is here support types with both const-generic and regular generics? Something like App<const U: usize, T> ?

I just let const before :, so the words after : will also work I think

I'm not sure about that, it seems to me that the pattern you used, $(@< $( const $lt:tt $( : $clt:tt $(+ $dlt:tt )* )? ),+ >)? would match a list like const U: usize, const V: usize, ..., but not a list mixing const arguments and regular type arguments?

Ah.. I see, I fogot that generic types can be muti types..

Ok, now it is ok.. I try add muti generic type,

like

struct A<const X: usize, Y: Sized, Z> {
     it: Z
}

it seems ok